feat(IP-routing): Enable IP forwarding and support multiple routes #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellipsis-dev
bot
changed the title
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me!
- Reviewed the entire pull request up to 26b9982
- Looked at
238lines of code in6files - Took 2 minutes and 13 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
1additional comments because they didn't meet confidence threshold of50%.
1. sdk/go/bastion/azure/bastion.go:38:
- Assessed confidence :
80% - Grade:
40% - Comment:
Consider adding a validation to check if the 'routes' array is not empty. An empty array for routes might not make sense and could lead to unexpected behavior. - Reasoning:
The PR author has changed the 'route' property to 'routes' and updated its type from string to array of strings in all the SDKs and schema. This change is consistent across all the files and seems to be correctly implemented. However, there is no validation to check if the array is empty. An empty array for routes might not make sense and could lead to unexpected behavior.
Workflow ID: wflow_EWDKwSku4YT4guAm
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR enables IP forwarding and updates the handling of routes to support multiple routes instead of a single one.
Key points:
userdata.tmplschema.yamlBastion.cs,bastion.go,bastion.ts, andbastion.pyto handle multiple routesGenerated with ❤️ by ellipsis.dev